Skip to content

update jedi dependencies to add python 3.13 support #24330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

update jedi dependencies to add python 3.13 support #24330

merged 1 commit into from
Oct 28, 2024

Conversation

@soda92
Copy link

@soda92 soda92 commented Oct 24, 2024

Once at a time I switched to jedi language server but find it didn't work.

I checked the error and find that the error was:

  File "***data\extensions\ms-python.python-2024.16.1-universal\python_files\lib\jedilsp\jedi\inference\__init__.py", line 91, in __init__
    self.grammar = environment.get_grammar()
                   ~~~~~~~~~~~~~~~~~~~~~~~^^
  File "***data\extensions\ms-python.python-2024.16.1-universal\python_files\lib\jedilsp\jedi\cache.py", line 112, in wrapper
    result = method(self, *args, **kwargs)
  File "***data\extensions\ms-python.python-2024.16.1-universal\python_files\lib\jedilsp\jedi\api\environment.py", line 37, in get_grammar
    return parso.load_grammar(version=version_string)
           ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
  File "***data\extensions\ms-python.python-2024.16.1-universal\python_files\lib\jedilsp\parso\grammar.py", line 264, in load_grammar
    raise NotImplementedError(message)
NotImplementedError: Python version 3.13 is currently not supported.

I tracked down and find that parso 0.8.4 added python3.13 support

So the dependencies needs to be updated

@soda92
Copy link
Author

soda92 commented Oct 24, 2024

@microsoft-github-policy-service agree

@soda92 soda92 changed the title update jedi dependencies update jedi dependencies to add python 3.13 support Oct 24, 2024
@soda92
Copy link
Author

soda92 commented Oct 24, 2024

https://pypi.org/project/parso/#:~:text=Add%20basic%20support%20for%20Python%203.13

@karthiknadig karthiknadig self-requested a review October 24, 2024 06:36
@karthiknadig karthiknadig self-assigned this Oct 24, 2024
@karthiknadig karthiknadig added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Oct 24, 2024
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Oct 28, 2024
@karthiknadig karthiknadig enabled auto-merge (squash) October 28, 2024 18:59
@karthiknadig karthiknadig merged commit b428ba5 into microsoft:main Oct 28, 2024
48 checks passed
@soda92 soda92 deleted the update-python-deps branch October 28, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@anthonykim1 anthonykim1 anthonykim1 approved these changes

@eleanorjboyd eleanorjboyd Awaiting requested review from eleanorjboyd

Assignees

@karthiknadig karthiknadig

Labels

debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Projects

None yet

Milestone

November 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@soda92 @karthiknadig @anthonykim1